From f53f1d73f517e7f5d47bda7ea41622657e0d5d30 Mon Sep 17 00:00:00 2001
From: heck <heck@pep.foundation>
Date: Thu, 3 Mar 2022 01:23:28 +0100
Subject: [PATCH] passphrase_cache: avoid copies (use const&)

---
 src/message_cache.cc | 6 +++---
 src/message_cache.hh | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/message_cache.cc b/src/message_cache.cc
index 6e6980c..f7b6989 100644
--- a/src/message_cache.cc
+++ b/src/message_cache.cc
@@ -75,13 +75,13 @@ namespace pEp {
             .encrypt_message_for_self(session, target_id, src, extra, dst, enc_format, flags);
     }
 
-    PEP_STATUS MessageCache::cache_release(std::string id)
+    PEP_STATUS MessageCache::cache_release(const std::string &id)
     {
         message_cache.release(id);
         return PEP_STATUS_OK;
     }
 
-    void MessageCache::release(std::string id)
+    void MessageCache::release(const std::string &id)
     {
         try {
             std::lock_guard<std::mutex> l(message_cache._mtx);
@@ -197,7 +197,7 @@ namespace pEp {
         return false;
     }
 
-    static ::message *empty_message_copy(const ::message *src, std::string _id = "", bool get_longmsg = false)
+    static ::message *empty_message_copy(const ::message *src, const std::string& _id = "", bool get_longmsg = false)
     {
         if (!src)
             return nullptr;
diff --git a/src/message_cache.hh b/src/message_cache.hh
index cd4aa2e..15e5486 100644
--- a/src/message_cache.hh
+++ b/src/message_cache.hh
@@ -74,11 +74,11 @@ namespace pEp {
             PEP_encrypt_flags_t flags);
 
 
-        static PEP_STATUS cache_release(std::string id);
+        static PEP_STATUS cache_release(const std::string& id);
         static void removeCacheID(::message *msg);
 
     protected:
-        void release(std::string id);
+        void release(const std::string& id);
 
         PEP_STATUS mime_decode_message(
             const char *mimetext,